department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Staging Review finding: Link for mileage rates opens in a new tab without warning #91796

Closed shiragoodman closed 1 week ago

shiragoodman commented 2 weeks ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Modernized Check-in Product: eCheck-in Feature: Mileage-only Travel Claim Submissions for VA Facilities that use Oracle Health EHR Software

Findings details

VA.gov Experience Standard - issue: User experiences an unexpected interaction with a component or pattern. VA.gov Experience Standard - category: Usability Launch-blocking: No Design System review: No Collab Cycle Reviewer: @erinrwhite (IA)

Description

On the "Select the appointment..." page, there is a “Check current mileage rates” link inside the blue additional info component that opens in a new tab without warning.

Link, screenshot or steps to recreate ![check-mileage-rates](https://github.com/user-attachments/assets/83962830-77ee-4a82-ad30-9e2221e9623f)

Recommended action

Add "(opens in a new tab)" to the link text.

References


Next Steps for the VFS Team

loripusey commented 2 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @brianseek @wullaski

brianseek commented 1 week ago

@benbrasso-agile6 @cgednalske @zach-park This is merged and ready to be validated locally, on stage, or in the screenshot in the PR: https://github.com/department-of-veterans-affairs/vets-website/pull/31776

benbrasso-agile6 commented 1 week ago

LG. Same for this one @zach-park, should be updated in Figma file + prod file.

brianseek commented 1 week ago

thanks UX friends. closing

zach-park commented 1 week ago

LG. Same for this one @zach-park, should be updated in Figma file + prod file.

Updated the "LoROTA Travel Reimbursement" Figma file. (Prod page is needed but on hold for now until UX team decide what to do for that for production) Cc: @benbrasso-agile6 @cgednalske