department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Staging Review finding: Consistency with page title of application #91797

Closed shiragoodman closed 1 day ago

shiragoodman commented 2 weeks ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Modernized Check-in Product: eCheck-in Feature: Mileage-only Travel Claim Submissions for VA Facilities that use Oracle Health EHR Software

Findings details

VA.gov Experience Standard - issue: User encounters content with errors or inconsistencies. VA.gov Experience Standard - category: Consistency Launch-blocking: No Design System review: No Collab Cycle Reviewer: @erinrwhite (IA)

Description

This application uses the same tag across all pages - `Travel Claim | Veterans Affairs'. This page title could be more descriptive and describe the purpose of the tool using active language. </p> <details><summary>Link, screenshot or steps to recreate</summary> ![title-tag-mileage-claim](https://github.com/user-attachments/assets/9770decd-51a7-4591-90be-750a5a4de4f7) </details> <h2>Recommended action</h2> <p>The first page in the app has the h1 "File a travel reimbursement claim" which seems to me to be the plain-language title of the form. I recommend updating the first segment of the title tag to match the h1 on the first page: <code>File a travel reimbursement claim | Veterans Affairs</code>. Refer to <a rel="noreferrer nofollow" target="_blank" href="https://design.va.gov/content-style-guide/title-tags">title tags guidance</a> for more information.</p> <h2>References</h2> <ul> <li><strong>Accessibility Defect Severity:</strong> N/A</li> <li><strong>WCAG Success Criteria:</strong> N/A</li> <li><strong>Modality:</strong> N/A</li> <li><strong>Design System Component:</strong> N/A</li> <li><strong>Design System Pattern or Template:</strong> N/A</li> <li><strong>Design System Foundation:</strong> N/A</li> <li><strong>Content Style Guide:</strong> <a rel="noreferrer nofollow" target="_blank" href="https://design.va.gov/content-style-guide/page-titles-and-section-titles">Page titles and section titles</a></li> <li><strong>Context:</strong> N/A</li> </ul> <hr /> <h3>Next Steps for the VFS Team</h3> <ul> <li>[ ] <strong>Questions?</strong> For the most timely response, comment on Slack in your team channel tagging <code>@platform-governance-team-members</code> with any questions or to get help validating the issue.</li> <li>[ ] <strong>Ticket ownership:</strong> If you believe that this issue is out of scope, not your team's responsibility, or a Design System issue, comment and tag <code>@platform-governance-team-members</code> on your team channel in Slack to provide an explanation and who you believe is responsible. The Governance team will follow up.</li> <li>[ ] <strong>Close this ticket</strong> when the issue has been resolved or validated by your Product Owner.</li> </ul> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/loripusey"><img src="https://avatars.githubusercontent.com/u/86678742?v=4" />loripusey</a> commented <strong> 2 weeks ago</strong> </div> <div class="markdown-body"> <p>@benbrasso-agile6 can UX make a recommendation for the new title?</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/loripusey"><img src="https://avatars.githubusercontent.com/u/86678742?v=4" />loripusey</a> commented <strong> 2 weeks ago</strong> </div> <div class="markdown-body"> <p>Hey team! Please <a href="https://app.zenhub.com/workspaces/Check-in-Experience-61fc23a2cb8a14001132e102/issues/department-of-veterans-affairs/va.gov-team/91797?planning-poker">add your planning poker estimate</a> with Zenhub @brianseek @wullaski</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/benbrasso-agile6"><img src="https://avatars.githubusercontent.com/u/101129355?v=4" />benbrasso-agile6</a> commented <strong> 2 weeks ago</strong> </div> <div class="markdown-body"> <p>I would recommend following the guidelines referenced in the ticket for each page of the app - <a href="https://design.va.gov/content-style-guide/title-tags">title tags</a></p> <p>[H1] | Veterans Affairs</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/brianseek"><img src="https://avatars.githubusercontent.com/u/13967174?v=4" />brianseek</a> commented <strong> 2 weeks ago</strong> </div> <div class="markdown-body"> <p>This one may be a bit tricky. It seems like the app name is getting injected as the title from content-build BUT <a href="https://github.com/s-yadav/react-meta-tags">react-meta-tags</a> is installed, so we can try that out to change title. I don't see other apps using it for that tag but I don't see why it won't work. We should add this to all apps in our wrapper. Pointing with that in mind</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/brianseek"><img src="https://avatars.githubusercontent.com/u/13967174?v=4" />brianseek</a> commented <strong> 1 week ago</strong> </div> <div class="markdown-body"> <p>@cgednalske / @benbrasso-agile6 / @zach-park This is merged and ready to validate locally, on stage (give like 20 mintues), or in the screenshots of the PR <a href="https://github.com/department-of-veterans-affairs/vets-website/pull/31800">https://github.com/department-of-veterans-affairs/vets-website/pull/31800</a></p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/benbrasso-agile6"><img src="https://avatars.githubusercontent.com/u/101129355?v=4" />benbrasso-agile6</a> commented <strong> 1 day ago</strong> </div> <div class="markdown-body"> <p>LGTM</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/brianseek"><img src="https://avatars.githubusercontent.com/u/13967174?v=4" />brianseek</a> commented <strong> 1 day ago</strong> </div> <div class="markdown-body"> <p>Thanks @benbrasso-agile6 ! closing</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>