search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Staging Review finding: Sentence structure in BTSSS filing copy #91799

Closed shiragoodman closed 3 days ago

shiragoodman commented 2 weeks ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Modernized Check-in Product: eCheck-in Feature: Mileage-only Travel Claim Submissions for VA Facilities that use Oracle Health EHR Software

Findings details

VA.gov Experience Standard - issue: User encounters content that does not meet best practices. VA.gov Experience Standard - category: Comprehension Launch-blocking: No Design System review: No Collab Cycle Reviewer: @kkitagawa-bosch (content)

Description

The phrase "If you need to submit receipts for other expenses like tolls, meals, or lodging, you can’t file a claim in this tool right now. But you can file your claim online, within 30 days, through the Beneficiary Travel Self Service System (BTSSS). Or you can use VA Form 10-3542 to submit a claim by mail or in person." has a similar issue to the travel-pay page ticket. Specifically, starting a sentence with the coordinating conjunction "or" can be confusing to readers who expect the conjunction to refer to something earlier in the same sentence.

The same issue is present in other versions of this copy, including on the travel-vehicle, travel-address, and travel-review pages.

Link, screenshot or steps to recreate https://staging.va.gov/my-health/appointment-travel-claim/travel-mileage https://staging.va.gov/my-health/appointment-travel-claim/travel-address https://staging.va.gov/my-health/appointment-travel-claim/travel-review

Recommended action

I would change the copy to "If you need to submit receipts for other expenses like tolls, meals, or lodging, you can't file a claim in this tool right now. But you can file your claim online, within 30 days, through the Beneficiary Travel Self Service System (BTSSS). You can also file by mail or in person using VA Form 10-3542."

References

Next Steps for the VFS Team

loripusey commented 2 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @brianseek @wullaski

brianseek commented 2 weeks ago

@loripusey we need to coordinate around translations. @wullaski had a good idea around waiting to make the change until after we get new translations.

wullaski commented 1 week ago

@loripusey, @brianseek brought up a good point that this work would make it so there wouldn't be Spanish and Tagalog translations for the strings. My idea was to wait until you are going to do another round of translations and make these changes right before. That way we minimize the time that we don't have strings translated for Spanish and Tagalog. This would put on hold this ticket, #91800 and #91798.

brianseek commented 1 week ago

one idea is that we could make the new keys for the updates, and also update the existing en key. Then make todos to swap the keys when we get the updated translations. We just need to remember to do it. Maybe a pattern in the key of something like something-something--UPDATE then if we see the UPDATE come in with translations, we know to swap them out and remove the UPDATE part.

loripusey commented 6 days ago

This sounds very convoluted, but I don't want to hold up the new English content from going out; if FE can manage this, then that's fine

brianseek commented 4 days ago

@cgednalske / @zach-park this is merged and ready to be validated locally or in the screenshots in this PR: https://github.com/department-of-veterans-affairs/vets-website/pull/31826

zach-park commented 3 days ago

LGTM. Thank you!

brianseek commented 3 days ago

Thanks @zach-park ! closing