department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Staging Review finding: Summary box for direct deposit information may not be appropriate #91802

Closed shiragoodman closed 6 days ago

shiragoodman commented 2 weeks ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Modernized Check-in Product: eCheck-in Feature: Mileage-only Travel Claim Submissions for VA Facilities that use Oracle Health EHR Software

Findings details

VA.gov Experience Standard - issue: User encounters design components or patterns that are inconsistent or confusing. VA.gov Experience Standard - category: Consistency Launch-blocking: No Design System review: No Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

On appointment-travel-claim/travel-pay, the "Set up direct deposit" section is in the va-summary-box component. The summary box is intended to highlight whatever is most important on the page, and as such is coded as a role="region", with the heading assigned as its aria-label:

<div class="usa-summary-box" role="region" aria-label="Set up direct deposit">

The region role makes this content extra discoverable for screen reader users --- which makes sense when it's the main point of the page, but is a little less useful when it's secondary content.

I think I would say the direct deposit information counts as secondary content here. It's important, since you definitely want to get your money! But it's not the reason people come to this page and it doesn't really need that special boost for screen reader users.

Having this be in a region doesn't really hurt anything, but it's a little strange to have this section get extra prominence relative to the rest of the page.

Link, screenshot or steps to recreate !["Set up direct deposit" section, presented in a light blue summary box.](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/working-with-vsp/vsp-collaboration-cycle/staging-review-images/Brian-75013-2.png?raw=true)

Recommended action

Review the guidance in VADS for the summary box and decide if this is an appropriate usage.

References


Next Steps for the VFS Team

loripusey commented 2 weeks ago

@benbrasso-agile6 Can you make a recommendation?

benbrasso-agile6 commented 2 weeks ago

Change to information alert per collab cycle feedback on Travel Pay Team and to align experiences between VFS products - https://www.figma.com/design/RzugGEmu4drhCSHTyQ6hjl/Simple-mileage-only-travel-pay-claim-submission?node-id=2501-9222&t=4TjqZSVL69WHFGnE-4

I'll updated our Figma file now.

benbrasso-agile6 commented 2 weeks ago

@loripusey - https://www.figma.com/design/pnR05o7NPJDS0KFUSQ0eE3/LoROTA-Travel-Reimbursement-%7C-PCI?node-id=642-3804&t=BfQrwkL6a6MR8eQ0-4

wullaski commented 1 week ago

@loripusey @benbrasso-agile6 this has been merged and ready to validate

benbrasso-agile6 commented 1 week ago

I see it in the PR. LGTM