department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

Staging Review finding: Error message not announced to screen reader users #91803

Closed shiragoodman closed 5 days ago

shiragoodman commented 2 weeks ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Modernized Check-in Product: eCheck-in Feature: Mileage-only Travel Claim Submissions for VA Facilities that use Oracle Health EHR Software

Findings details

VA.gov Experience Standard - issue: User doesn't have enough information to complete a task. VA.gov Experience Standard - category: Comprehension Launch-blocking: Yes Design System review: No Collab Cycle Reviewer: @briandeconinck (Accessibility)

Description

On appointment-travel-claim/travel-review, if you click "File claim" without checking the "I confirm" checkbox, you get an inline error message on the checkbox, "You must accept the beneficiary travel agreement before continuing."

However, this error message isn't currently announced to screen reader users. If a screen reader user attempts to file without checking the box, nothing is announced. Without any visual cues, you've got to guess what happened. Did it work? Was there an error? Is this page just broken? etc.

Link, screenshot or steps to recreate !["Beneficiary travel agreement" section, with an error message appearing inline with the checkbox confirming your agreement. The "File claim" and "Start over" buttons are just below this section, with a keyboard focus indicator visible around the "File claim" button.](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/working-with-vsp/vsp-collaboration-cycle/staging-review-images/Brian-75013-3.png?raw=true) Steps to reproduce: 1. Use a test user to navigate through the travel claim flow until you reach the review page. 2. Activate a screen reader (easiest for testing with VoiceOver on Mac or NVDA on Windows). 3. Press [tab] until "File claim" has focus, and press [enter]. 4. Observe that nothing is announced to the user.

Recommended action

In the forms library when an inline error is triggered, keyboard focus is sent to the input that has the error. This ensures that the input, its state, and the error message are immediately announced to screen reader users, and puts keyboard focus in an actionable place to resolve the error. It would be great to match that behavior.

References


Next Steps for the VFS Team

loripusey commented 2 weeks ago

Hey team! Please add your planning poker estimate with Zenhub @brianseek @wullaski

wullaski commented 1 week ago

@loripusey this has been fixed and can be closed.