department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

Staging Review finding: Change the alert style from warning to info #91810

Open shiragoodman opened 3 months ago

shiragoodman commented 3 months ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: Benefits Management Tools Product: Claim Status Tool Feature: Improved 5103 requests and waiver experience

Findings details

VA.gov Experience Standard - issue: User encounters design components or patterns that are inconsistent or confusing. VA.gov Experience Standard - category: Consistency Launch-blocking: No Design System review: No Collab Cycle Reviewer: @allison0034 (Design)

Description

There is a warning alert that informs the user to upload a waiver if they have no evidence. It seems the user can also do nothing and the claim will move to the next step on a specific date. Per our guidance, warning alert styles are for negative consequences, or when something has gone wrong, however since the user can opt to do nothing, there seems to be no negative consequence.

Recommended action

If there are no negative consequences, remove the warning alert style and make it the blue info alert.

References


Next Steps for the VFS Team

jacobworrell commented 2 months ago

@shiragoodman I think we discussed this in staging review and after we described the process, we agreed that there were sometimes still negative consequences to not submitting the waiver. It's not consistent, but I think we all agreed the design pattern was more appropriate in light of that.

Permission to close this ticket?

allison0034 commented 2 months ago

Yes! We did discuss and yes you can close.

shiragoodman commented 2 months ago

I agree with @allison0034 . Thanks for raising this @jacobworrell