Update appointment request type logic to accommodate Cerner appointments

simiadebowale commented 2 months ago

Description

We want to enhance our appointment request logic to accommodate Cerner appointments. Booked Cerner appointments will still have requestedPeriods. To support this, we want to update the logic for requests to:

if (isCerner && isEmpty(appt?.end)) {
    return APPOINTMENT_TYPES.request;
  }
  if (isCerner && !isEmpty(appt?.end)) {
    return APPOINTMENT_TYPES.vaAppointment;
  }

This will be a temporary FE change till the vets-api consolidation work is done.

Development Checklist

[ ] Update request type logic
[ ] update tests

Developer Reference

src/applications/vaos/services/appointment/transformers.js

Definition of Done

[ ] All tasks criteria are met
[ ] [Technical Documentation]() is updated (must confirm if needed/or remove)

ldelacosta commented 3 weeks ago

Need to move this ticket to External Dependencies. Staging for OH is down until 11/19.

Issue: Appointments from OH is not shown in staging.

Waiting until OH is available in staging to re-validate.

cc: @JRRoof @simiadebowale @Bren22va

ldelacosta commented 3 weeks ago

Slack thread VPG team ticket

ldelacosta commented 2 weeks ago

Blocked to validate this ticket. Waiting for VPG team to release their changes. Ticket to track.

department-of-veterans-affairs / va.gov-team