search

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 197 forks source link

https://github.com/department-of-veterans-affairs/vets-api/p... #92343

Closed platform-support-slack-integration[bot] closed 6 days ago

platform-support-slack-integration[bot] commented 1 week ago

Submitted By: drew.fisher Topic: Something Else Team: Tier 1 Support

https://github.com/department-of-veterans-affairs/vets-api/pull/18216 was created by a team outside of the codeowners of the claims module, and had no input or approval from the codeowning team before merge. The codeowning team wasn't even notified of the changes, and had to scramble to understand the changes when they pulled after the merge.

This feels like a process misstep - many PRs wait for e.g. backend-review-group approval before merge, but the same approval requirement wasn't in place for the codeowners in this case. Can someone investigate to make sure that the approval gate exists for codeowning teams so they're not caught off guard & have input into the PRs changing their code?

platform-support-slack-integration[bot] commented 1 week ago

Slack Thread Link: https://dsva.slack.com/archives/CBU0KDSB1/p1725645349684919