department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

[FE] Choose a date & Time - design update #92483

Closed lee-delarm6 closed 1 month ago

lee-delarm6 commented 1 month ago

Update design and error states:

https://www.figma.com/design/DsRXEFiYLCFnY5nBkp9Dc4/CC-Referral-%7C-Appointments-FE?node-id=2217-61186&node-type=FRAME&t=4N7qTNCN0vsYSxVV-0

Location: src/applications/vaos/referral-appointments/ChooseDateAndTime.jsx

lee-delarm6 commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @brianseek @wullaski

brianseek commented 1 month ago

@benbrasso-agile6 / @cgednalske / @zach-park This is merged and ready for validation, see screenshot.

*note breadcrumb TBD with the work Lee is doing now

localhost_3001_my-health_appointments_provider-choose-date-and-time.png
benbrasso-agile6 commented 1 month ago

Looks nice.

Are we able to auto-format that phone to use the tel attribute?

Remove please. I updated Figma too.

Note: this page might change due to design changes. But, it fits the design you were working off of.

What's that little checkmark? Is that in the custom calendar component?

brianseek commented 1 month ago

I can make those updates in the ticket that I'm working on now since its still part of this page.

Yeah the checkmark is part of that component, its weird looking but intentional seeming.

benbrasso-agile6 commented 1 month ago

Well based on what I was saying in Slack, you might want to wait. I pinged Ciera on her ticket to make a decision.

brianseek commented 1 month ago

@benbrasso-agile6 I don't think that conversation will change what I'm doing on this date picker page. I'll just add a running list of changes needed in that ticket and close this one up.

benbrasso-agile6 commented 1 month ago

Yeah; I think we're on the same page. Just trying not to mess with your PRs or whatevs.