[FE] [TECH DEBT] - update to use button pair - Githubissues

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:

https://depo-platform-documentation.scrollhelp.site/index.html

284 stars 206 forks source link

[FE] [TECH DEBT] - update to use button pair #92500

Open brianseek opened 2 months ago

brianseek commented 2 months ago

Description

The <va-button-pair> component now allows custom text. We should update our confirmable pages and travel pages to use the component.

https://design.va.gov/storybook/?path=/docs/uswds-va-button-pair--docs

Tasks

[ ] Update our two button usage to use va-button-pair
[ ] Create or update unit tests
[ ] Create or update e2e tests
[ ] Update relevant documentations (readme and use cases)

Acceptance Criteria

[ ] Passes Accessibility checks using axe
[ ] Deployed to staging.
[ ] Tested on staging
[ ] Designer has signed off on the feature
[ ] Product team has signed off on the feature
[ ] Prod validation:
- [ ] not necessary
- [ ] scheduled

Code Review Steps

[ ] Read ticket details and verify that ACs are met
[ ] Review code in PR
[ ] Run branch locally
[ ] Check that new and updated translations use new keys
[ ] Check for hardcoded strings

brianseek commented 2 months ago

Please add your planning poker estimate with Zenhub @wullaski