department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

FE | Appointment Reminder PHI/PII | Add Facility and Clinic Details Checkbox for Health Appointment Reminders in Notification Settings #92656

Open asiisii opened 2 months ago

asiisii commented 2 months ago

Issue Description

Summary

We need to implement a new functionality for the "Your Health Care" communication group on the Notification Settings page, specifically for the "Health appointment reminders" item. This item currently has two notification channels:

Each channel has a checkbox with labels:

New Functionality

ℹ️ Info:
The section should only be visible when at least one of the channel checkboxes (Notify me by email or Notify me by text) is checked, and the newly created toggle is turned on.

Tasks

Backend Integration Questions

[!WARNING] VA Profile's work will block us - PoC is Autumn A.

Before we can fully implement this functionality, we need to clarify the following with the backend team:

We need these details to ensure smooth and accurate implementation of the frontend functionality.

Related Design Ticket

Acceptance Criteria

mtcA6 commented 2 months ago

@asiisii Added the figma file.

My only question is related to this section: image

Want to make sure when we go to build this we don't have any confusion about the conditional reveal. If [a channel] is selected the user should only see the permission related to [a channel]. Want to make sure the conditional review only reveals the related field. The only time the conditional reveal should show the permission for both channels is if both channels are selected.

mtcA6 commented 2 months ago

and I'm wondering if we need another toggle :/

asiisii commented 2 months ago

@asiisii Added the figma file.

My only question is related to this section: image

Want to make sure when we go to build this we don't have any confusion about the conditional reveal. If [a channel] is selected the user should only see the permission related to [a channel]. Want to make sure the conditional review only reveals the related field. The only time the conditional reveal should show the permission for both channels is if both channels are selected.

@mtcA6 Thank you for reviewing the ticket. I just updated the conditional display section to be more clear and descriptive. And yes, we will need a new toggle. I was going to ask you what we are going to name it during our sprint planning. I added a new section called "New feature toggle" in this ticket

mtcA6 commented 2 months ago

thoughts on profileShowNotificationSettingsAppointmentPhiPiiPermission