department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 201 forks source link

[SC][TEST]: Manage focus on review and submit page after clicking edit #92801

Open davidakennedy opened 2 weeks ago

davidakennedy commented 2 weeks ago

What happened?

Describe what went wrong:

When you click on many of the edit buttons on the review and submit page, focus is lost.

Add the steps to reproduce the bug:

  1. Go to https://staging.va.gov/decision-reviews/test-sc/ and start filling out the form.
  2. Navigate to https://staging.va.gov/decision-reviews/test-sc/review-and-submit
  3. Expand the accordions.
  4. Activate one of the edit buttons.
  5. Note that focus is lost.

Add a screen recording or photo:

Private Zenhub Video

How severe is the problem?

What is the desired behavior?

  1. When a user activates the edit button on of a question, the visual result is focus is shifted.

We should shift focus to the input field of the associated question. If there isn't an input, to a heading or first line of text.

Definition of Done

Mottie commented 2 weeks ago

This appears to be a duplicate of #74925 where our focus functions aren't working as expected on nested web components. I'll go ahead and continue work on this problem.

eileen-coforma commented 1 week ago

Still in progress

Mottie commented 1 week ago

Will open a PR ~today~ soon