[FE, QA] 10-10CG - Improvement: Explore Secondary CGs when Yes, then No is selected

[hdjustice]

Benefit to the Veteran

As a Veteran/Caregiver, I want the application to perform according to my selections, so that I am confident in the data that I have entered and want included on the form.

Background

Test finding from CG tech team:

• Gaspare brought up that SCG 1 and 2 issues
  • Weird thing happened.
  • Enter primary CG, then select Yes and enter secondary CG, select yes to add additional secondary CG, then go back to select No to secondary CG (not the "additional), the form retains the info on additional secondary CG
  • Then the user can move forward through the form after going back to select No on secondary CG, but the form does not flow through the additional secondary CG pages, nor does it allow to remove the additional secondary CG input
  • Ideal function: application will either remove all secondary CGs when No is selected at any time (including after going back through the form).

Scope

• Set the form to remove all identified secondary caregivers when the initial "Do you want to add a secondary caregiver" question is answered No at any time before submission

Tasks

• [x] Update UI to remove all secondary and additional secondary caregiver data when the initial "Do you want to add a secondary caregiver" question is answered No at any time before submission
• [x] Validate that any time this question is answered No, even if data has been entered for a secondary and/or additional secondary caregiver, that all the secondary/additional secondary caregiver data has been deleted/removed from the form on submit
• [ ] QA/PM to validate page flow and functionality
  • Signoff in the comments is required prior to launch
• [ ] PM to inform CG stakeholders of the update and validation
• [ ] Launch to production

Acceptance Criteria

• The 10-10CG form has been updated to ensure all secondary caregiver data is removed when the initial secondary caregiver question is answered No.

[longmd]

@allanto-ah , this one is ready for QA review. Should be a quick review for this one. I validated by using the comparing the Redux data to the payload from the Network tab and verified the payload is as they would desire. Here is the Review Instance link

[allanto-ah]

Environment: RI

Looks good in the Review Instance. Once this goes to staging, will do an E2E with CARMA

[longmd]

We should be able to do e2e with CARMA from the RI using +36--Wesley Watson Ford.

[allanto-ah]

Oh hmm, I submitted a couple forms in the RI, but when I asked CARMA they don't see it in their staging environment. Is there another environment I should be asking them to check?

[longmd]

I think they have one called pre-prod. You might try having them check that.

[hdjustice]

Unless they've made a change in their environments, our connections should not have changed since the last time we tested with them. Not sure why the submission is not going thru.
Also - here is a doc we created to help with test env across the various endpoints

[allanto-ah]

CARMA is receiving the submission as expected when I'm submitting using our staging environment, but not when I'm using the RI. They said there hasn't been any changes on their side either: Slack thread

[longmd]

@allanto-ah / @hdjustice , I think we may have found the issue. Since the new oAuth 2.0 authentication is still behind a feature flag, it was not turned on by default in the Review Instance. I just turned it on and did a submission. I am waiting on verification from CARMA. Marla said many of them are traveling today, so we may have to wait until tomorrow for confirmation.

[hdjustice]

d'oh! that would do it. Great find!