department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
282 stars 203 forks source link

686 | Trigger for Action Needed Email #93107

Open steele-lm opened 1 month ago

steele-lm commented 1 month ago

Issue Description

For any async job where we've accepted the payload from the vets-website... if we've called an async job, meaning one that we aren't notifying the veteran of a failure, we need to do the following:

  1. Log it.

You can use this lib/zero_silent_failures/monitor.rb to help you do the logging. Here are examples of usage: https://github.com/department-of-veterans-affairs/vets-api/pull/18941/files

  1. Send an email a. We should be able to get the VA-notify template ID's from Fiorella.

Also, here is some documentation that may help: https://github.com/department-of-veterans-affairs/va.gov-team-sensitive/blob/maste[…]tform/practices/zero-silent-failures/logging-silent-failures.md

Resources


Tasks

Acceptance Criteria

steele-lm commented 2 days ago

@evansmith Dene shared that for stage 1, we'll send two separate emails to the Veteran if they submit a 674 with a 686. In the future, @fiorella-io will work on a single custom email template that will be sent to a Veteran if both forms fail. I'll create a new ticket to cover the combined 686/674 failure.

steele-lm commented 2 days ago

@evansmith I also updated the AC to call out that the failure email for 686 (and all other forms) should be sent to the email the user enters into the form. If they did not enter an email into the form, use their profile email.