department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
281 stars 198 forks source link

Remove unnecessary aria attributes from appts lists #93285

Open outerpress opened 2 hours ago

outerpress commented 2 hours ago

Description

The appointments lists have some overzealous aria labelling that can be removed to clarify for screenreader users. See CC ticket #55864 and #55851 for full context on these changes. These changes are for both the upcoming and past appts lists.

  1. For the aria-label on a div in the first column of each appointment:
Screenshot_2024-09-20_at_8_43_37 AM.png
  1. Remove <span class="sr-only">Appointments in</span> from the H2 month/year headings:
Screenshot 2024-09-20 at 8.47.52 AM.png
  1. Remove the aria-labelledby attribute from the ul that follows the heading. The context of the heading is enough to create the association. (Also remove the ID on the heading if this isn't being used for other functionality).
Screenshot 2024-09-20 at 8.58.59 AM.png

Development Checklist

Background: the toggle toggle is on (remove if not needed)

Design Assets

Developer Reference

Definition of Done


How to configure this issue (Delete this section before creating the ticket)

outerpress commented 2 hours ago

@ldelacosta this is to address feedback in an old collab cycle ticket - #55864