department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

Staging Review finding: left arrow in Back navigation not rendered with va-icon #93705

Open shiragoodman opened 2 months ago

shiragoodman commented 2 months ago

Need help? Please review how to read a Staging Review ticket. Tag @platform-governance-team-members on Slack if you need further assistance.

Product Information

Team: vfs-mhv-secure-messaging Product: MHV Secure Messaging Feature: Contact List

Findings details

VA.gov Experience Standard - issue: User encounters a component or pattern that isn't considered a best practice. VA.gov Experience Standard - category: Consistency Launch-blocking: No Design System review: No Collab Cycle Reviewer: @it-harrison (QA)

Description

The left arrow or chevron int he Back navigation ont he contact list page is not rendered using the va_icon#left_chevron which I believe is the. standard on va.gov

Link, screenshot or steps to recreate ![left arrow](https://github.com/department-of-veterans-affairs/va.gov-team/blob/master/platform/working-with-vsp/vsp-collaboration-cycle/staging-review-images/90850_ian_1.png?raw=true)

Recommended action

Use the va_icon#left_chevron

References


Next Steps for the VFS Team

lichellebain commented 2 months ago

https://jira.devops.va.gov/browse/MHV-62481

KyleCardwell commented 1 month ago

@shiragoodman Hello! After discussing with UCD, we think it might be possible to replace the left chevron completely and use a va-icon back arrow. That way it will more closely align with the VADS Breadcrumbs component. Would that be an acceptable alternative to the left chevron icon? Image

shiragoodman commented 1 month ago

Tagging my team for input. @it-harrison @allison0034 @humancompanion-usds please see Kyle's comment above and let them know if that's an acceptable solution.

allison0034 commented 1 month ago

@KyleCardwell you can use the back link component.