department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:

https://depo-platform-documentation.scrollhelp.site/index.html

282 stars 202 forks source link

VR&E User UUID is being used in sidekiq #93953

Open mjknight50 opened 2 weeks ago

mjknight50 commented 2 weeks ago

Overview

The VR&E controller is passing the current_user to sidekiq which is a problem with the async nature of that job. https://github.com/department-of-veterans-affairs/vets-api/blob/master/app/controllers/v0/veteran_readiness_employment_claims_controller.rb#L13

Tasks

[ ] - Switch to the user_account_uuid

sanjabaj2 commented 2 weeks ago

Do we have past cases where this happened and we lost the submission? If so, another ZSF:Remediation ticket should be opened if we can find those failed cases.

evansmith commented 1 week ago

This will be slightly more involved than just passing a different uuid. We'll use the same scheme of an encrypted user_struct to imitate a user so that we don't have to rely on attempting to find the user in the job.