Global | Manage focus on review & submit page on submit error - Githubissues

department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:

https://depo-platform-documentation.scrollhelp.site/index.html

282 stars 203 forks source link

Global | Manage focus on review & submit page on submit error #94687

Open Mottie opened 1 week ago

Mottie commented 1 week ago

What happened?

Describe what went wrong:

When you click on submit button on the review and submit page, focus is lost.

Add the steps to reproduce the bug:

Go to https://staging.va.gov/decision-reviews/test-sc/ and start filling out the form.
Navigate to https://staging.va.gov/decision-reviews/test-sc/review-and-submit
Submit the form without checking the privacy policy checkbox
Note that focus is lost.
Open the "Issues for review" accordion
Edit the first page
Uncheck all issues
Scroll down and submit the form again (skip the "Update page" button)
Note that focus is lost

Add a screen recording or photo:

How severe is the problem?

[x] Critical: User is block or significantly hindered from submitting the form, data is lost, or claim and evidence test coverage is missing. Fix ASAP.
[ ] Moderate: User is not blocked, but the happy path is interrupted. Fix after critical bugs.
[ ] Minor: Cosmetic bugs and minor language inconsistencies. Defer to a later sprint.

What is the desired behavior?

When a user activates the submit button, the is focus is shifted.

We should shift focus to the checkbox field of the privacy policy, and if checked and an error alert becomes visible, focus on the alert

Definition of Done

[ ] Acceptance criteria reviewed and approved by product or design
[ ] Unit test (or other test coverage) added if possible
[ ] Logging and monitoring in place

comaurice commented 5 days ago

Pending a code review, CI tests are failing right now