department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

User submissions failed due to empty disabilities array #95368

Open sethdarragile6 opened 2 weeks ago

sethdarragile6 commented 2 weeks ago

On Friday, 10/11, 3 duplicate submissions (in close succession) from 1 unique user entered the backup path and failed due to an empty disabilities array in their submit request. Eventually, the user was able to submit successfully (with a fully-populated disabilities array).

Relevant Links

sethdarragile6 commented 6 days ago

Another occurrence came in on 28 Oct 2024 21:14:09.606957000 UTC +00:00, submission id 3158246

sethdarragile6 commented 6 days ago

@aurora-a-k-a-lightning pointed out that the main issue is that these users are somehow submitting claims with no "NEW" or "INCREASE" disabilities (i.e. all their ratedDisabilities are marked "NONE")- which is not supposed to be allowed.

A stop-gap fix here would be to catch this situation, return an error in the submit_all_claim response, since the disability array is constructed in our translate method