User submissions failed due to empty disabilities array

sethdarragile6 commented 1 month ago

On Friday, 10/11, 3 duplicate submissions (in close succession) from 1 unique user entered the backup path and failed due to an empty disabilities array in their submit request. Eventually, the user was able to submit successfully (with a fully-populated disabilities array).

per Maya, this could be related to the V3 upgrade of the component used for disabilities (according to the contentions team)
per Emily, this could be related to users returning with an old IPF record that contains disabilities that no longer exist in the dropdown

Relevant Links

Datadog link
although submissions don't appear to be BDD-related, this bug also reported an empty disabilities array

sethdarragile6 commented 1 month ago

Another occurrence came in on 28 Oct 2024 21:14:09.606957000 UTC +00:00, submission id 3158246

sethdarragile6 commented 1 month ago

@aurora-a-k-a-lightning pointed out that the main issue is that these users are somehow submitting claims with no "NEW" or "INCREASE" disabilities (i.e. all their ratedDisabilities are marked "NONE")- which is not supposed to be allowed.

A stop-gap fix here would be to catch this situation, return an error in the submit_all_claim response, since the disability array is constructed in our translate method

sethdarragile6 commented 2 weeks ago

Here is an instance of the BE stop-gap fix working, in case it's useful in diagnosing

department-of-veterans-affairs / va.gov-team

User submissions failed due to empty disabilities array #95368

Relevant Links