department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 205 forks source link

Update Datadog board to show descriptive error logs and latency data #95531

Open cloudmagic80 opened 3 weeks ago

cloudmagic80 commented 3 weeks ago

Copy the "UploadsController#submit Errors" section from Simple Forms dashboard and adapt it to our needs.

image.png
michaelclement commented 1 week ago

For this, we may want to take advantage of this new vets-api ZSF logging monitor class (subclass of this new logger) that was added recently by another team. We should be able to replace our existing logging using this interface, which will standardize the messages we see + give us more information.

We can create our own subclass of ::ZeroSilentFailures::Monitor and start replacing the inner workings of our current tracking functions across the various models (e.g., track_user_identity, track_current_user_loa, etc).

michaelclement commented 6 days ago

Another note - it looks like our graph in DD is set up the same as Simple Forms' already. The issue is that when they receive an error, they throw an instance of SimpleFormsApi::Exceptions::ScrubbedUploadsSubmitError, which has a message member (which is what's supposed to be displayed in that @ERROR.MESSAGE column. So that's something we'll need to either adapt or replace

cloudmagic80 commented 5 days ago

department-of-veterans-affairs/vets-api#19370 department-of-veterans-affairs/vets-api#19253