[x] Assign this ticket to the team member(s) responsible for addressing feedback provided by Platform.
[ ] Comment on this ticket:
If the Platform reviewer has any Thoughts/Questions that require responses.
When Must feedback has been incorporated. As appropriate, link to any other GitHub issues or PRs related to this feedback.
When Should/Consider feedback has been incorporated, or if any feedback will not be addressed. As appropriate, link to any other GitHub issues or PRs related to this feedback.
[ ] Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members.
[ ] Close the ticket when all feedback has been addressed.
Thoughts/questions
No major concerns! Looks good!
Feedback
Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).
[ ] Coding note: Thinking about a screen reader user's experience --- there are two pieces of information that need to be communicated to users when they've completed the check-in flow: (1) they're checked in, and (2) they need to let the staff know they've arrived. As I remember the current state, focus goes to the H1 on the last screen, which means screen reader users will definitely hear "Let a clinic staff member know when you've arrived," but if a screen reader user puts their phone away they may not realize the text that follows is even there. I think the best option here is referencing the "You're checked in online" paragraph with aria-describedby, so that when focus lands on the H1 you hear the H1 text and then the paragraph text all in one announcement.
Something like that may also be needed earlier in the flow, depending on where the "You'll need to find a clinic staff member" text ends up going. And of course all of this depends on where the final design lands!
[ ] Should [Martha]: Reminder to keep text as concise as possible.
Governance team actions
[x] Format feedback as individual tasks (check boxes)
[x] Assign this ticket to the VFS team member that opened the Slack request
[x] Add the VFS team product label
[x] Add the VFS team the feature label (if applicable)
[x] Add the touchpoint labels
[x] Add the practice area labels
[x] Add the Collaboration Cycle initiative milestone
Next Steps for the VFS team
@platform-governance-team-members
.Thoughts/questions
Feedback
Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).
[ ] Coding note: Thinking about a screen reader user's experience --- there are two pieces of information that need to be communicated to users when they've completed the check-in flow: (1) they're checked in, and (2) they need to let the staff know they've arrived. As I remember the current state, focus goes to the H1 on the last screen, which means screen reader users will definitely hear "Let a clinic staff member know when you've arrived," but if a screen reader user puts their phone away they may not realize the text that follows is even there. I think the best option here is referencing the "You're checked in online" paragraph with
aria-describedby
, so that when focus lands on the H1 you hear the H1 text and then the paragraph text all in one announcement.Something like that may also be needed earlier in the flow, depending on where the "You'll need to find a clinic staff member" text ends up going. And of course all of this depends on where the final design lands!
Governance team actions