department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

[GitHub Action] Helm Chart Versioning #96205

Open ph-One opened 2 weeks ago

ph-One commented 2 weeks ago

Description

People forget to bump the version of helm charts when making updates to templates. If a Pull Request modifies a chart but the changelog does not include Chart.yaml, fail the workflow/check.

Acceptance Criteria

Refinement Guidance - Check the following before working on this issue:

Efe-Oddball commented 1 day ago

I have written a workflow that checks to see if there is a modification within a helm deployment, then checks if the particular deployment chart.yaml version is updated or not. I am going to start testing, but also considering if I should force the check upon PR creation or upon PR merge

Efe-Oddball commented 2 hours ago

I have tested the workflow for this implementation and pushed out a PR

Efe-Oddball commented 2 hours ago

Once the PR is approved and merged, I will add the work flow as a merge condition to block any merge in which a change was made to any helm configuration, and the corresponding chart.yaml version was not upgraded

Efe-Oddball commented 2 hours ago

Moving this ticket to a review state