department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

Self-Service: Pre-Need: Supporting documents section is accepting PDFs larger than the maximum allowed #96266

Open MichelleDieudonne opened 1 month ago

MichelleDieudonne commented 1 month ago

This bug will need to be fixed and tested in both Pre-Integration and Integration

The Pre-Integration fix will need to be placed behind a PROD flag until the bug passes UAT.

Details:

Currently for supporting documents are accepting PDFs larger than the maximum allowed size `78" x 101", We need to validate that documents meet the current restrictions for the benefits intake API using the lighthouse validate_document endpoint.

Issue: If a PDF is larger than the maximum size allowed it will cause an error/failure

Feature Flag Status : N/A (Yes/No/Does not Impact)

Steps to reproduce:

fill out the 40-10007 form in for pre-integration and stop at the supporting documents page Upload a pdf larger that 78" x 101" Observe that the document is taken as valid and you can progress Expected results:

An error should be shown to the user if the pdf dimensions are above the 78" x 101" threshold.

Actual Results:

No error is shown and all PDFs, regardless of size in inches are being accepted

humancompanion-usds commented 1 month ago

No error is shown and all PDFs, regardless of size in inches are being accepted

@MichelleDieudonne - Are those submissions being accepted and processed? Or are they causing an error downstream? If there is an error, are they routed to a human? How many of the PDFs you have accepted fall into this category?

ksantiagoBAH commented 1 month ago

This was the downstream error received

2024-09-01T04:00:13.260Z dd2441ca-f087-4cf4-9add-8fd9cd679e65 “40-10007” Form Submission Attempt State change DOC202: “Upstream status: Errors: ERR-EMMS-FAILED, Corrupted File detected. EMMS-GCIO-17416042, File: EMMS-GCIO-23296306.xml;”

Checked with CMP and they said it failed because on of the pdfs was way too big