department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

[a11y-defect-2]: Edit Benefit Letters update address buttons must be contextual for assistive technology users #96346

Open 1Copenut opened 4 days ago

1Copenut commented 4 days ago

Point of contact

Trevor Pierce

Severity level

2, Serious. Should be fixed in 1-2 sprints post-launch.

Details

When Benefit Letter users update their address, we have a secondary routine that asks users to confirm their address. They can either use the address as entered or use the USPS recommended address. In this routine, the primary action button says "Use this address" but non-sighted users have no context what "this" means in this case. It could lead to a situation where errors are introduced or addresses incorrectly updated. Screenshot attached.


Image

Reproduction steps

  1. Log into https://staging.va.gov/records/download-va-letters/letters/confirm-address with a test user who has benefit letters. I used 54.
  2. Turn on a screen reader of your choosing
  3. Click the "Edit" button to switch the mailing address to the inline form
  4. Edit or change one or two fields in the form
  5. Press the "Save" button
  6. Verify the updated alert box announces itself to your screen reader
  7. Tab to the Use this address button and consider how important it is to know if you're using the suggested or as entered address

Proposed solution or next steps

The button text should be more descriptive and should be contextual to which radio button users have selected. That way they have a chance to know what address is being used and double check as they feel necessary.

References, articles, or WCAG support

  1. Understanding SC 1.3.1: Info and Relationships (Level A)
  2. Understanding SC 3.3.4: Error Prevention (Legal, Financial, Data) (Level AA)

Type of issue