department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

Lookup rep and org info for next steps email #96351

Open opticbob opened 4 days ago

opticbob commented 4 days ago

Background

There are some validation issues with the interplay between the frontend and the backend for the next steps email endpoint. We are going to move from sending a rep name, address, and type to sending a entity_type and entity_id so those values can be looked up on the backend. This will make it easier to cover both selections of individuals and orgs as a whole.

Tasks

Acceptance Criteria


How to configure this issue

  1. Label with practice area (backend, frontend,ux, design, research)
  2. Label for MVP work? (mvp)
  3. Add an estimate
  4. Attach an Epic (what body of work is this a part of?)
opticbob commented 1 day ago

I'm working on fixing the last test and the PR for this will be ready for review. I anticipate that happening early tomorrow morning.

opticbob commented 2 hours ago

@holdenhinkle Has approved the PR for this. If platform hasn't approved it by 11:15 CST tomorrow I'll ping them.