department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 204 forks source link

[DESIGN] Create error state for when travel link cannot be retrieved #96578

Open cgednalske opened 1 week ago

cgednalske commented 1 week ago

Background

Based on this discussion, we'll need an error state for when a when there’s an error fetching the travel claim link from the api.

Appointments team already has this in place for AVS, which we should likely follow while ensuring this does not present any new page concerns: AVS error state pattern

Some questions to consider:

(Reach out to John W. and Simi with any questions)

Tasks

A/C

zach-park commented 6 days ago

Hey team! Please add your planning poker estimate with Zenhub @cgednalske @StevenStraily

loripusey commented 6 days ago

@zach-park if you guys are going to continue to use Planning Poker (which is a ZenHub feature that will be going away towards the end of the year), please remember to copy the estimate into the Estimate field for the ticket inside the GitHub project. Image

cgednalske commented 6 days ago

We can probably just comment here in the ticket or in a related Slack thread moving forward.

My vote was a 2‍⃣

cgednalske commented 4 days ago

@zach-park @StevenStraily want to add your estimates?

StevenStraily commented 4 days ago

I voted 3 in the poker.

cgednalske commented 1 day ago

@loripusey This ticket is more important than the breadcrumb ticket, so if we need to take anything out, we can remove the breadcrumb ticket and @zach-park can work on this one instead.

cgednalske commented 1 day ago

Based on our pointing discussion, proposing this is a 2‍⃣

zach-park commented 51 minutes ago

FYI, FE ticket: https://github.com/department-of-veterans-affairs/va.gov-team/issues/96580