BE | Profile | Military Service History | Fix user reference for academy attendance feature flag

[tpharrison]

Summary

When retrieving military history records for a veteran, there is a conditional check in place that uses the profile_show_military_academy_attendance feature flag to determine whether to display academy attendance records.

The code checks the flag using the @current_user on line in the VAProfile::MilitaryPersonnel::Service. The @current_user is returning nil. It should be changed from @current_user to @user.

Tasks

• [ ] Determine if this code should be removed along with the feature flag.
• [ ] Either remove logic or change @current_user to @user.

Acceptance Criteria

• [ ] Code is removed or fixed.

[ACParker89]

@tpharrison do we need an epic for this or do you see it looped into a past effort?

[tpharrison]

@ACParker89 There might be an old epic out there, but I'm not sure what it is. I don't think it needs one.