department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
283 stars 205 forks source link

Include specific 21-22a authorizations (Fields 19a and 19b) in PDF generation #96908

Open oddball-lindsay opened 4 days ago

oddball-lindsay commented 4 days ago

The 21-22a form has unique authorizations (Field 19a and 19b) that we need to make sure to fill out, based on the user's input.

The frontend should be passing this to the backend in https://github.com/department-of-veterans-affairs/va.gov-team/issues/96848. And the backend will need to add the input to the 21-22a PDF when it is generated.

Tasks

Acceptance Criteria

opticbob commented 3 days ago

The first thing to do here is to determine what the shape of the additional frontend request data will look like. I plan to ping @cosu419 in the morning to discuss it.

opticbob commented 2 days ago

I made a plan with @cosu419 for how we would send the question 19 data between the frontend and backend. As of right now I can check both boxes and fill text in both fields.

I'll ask this in slack tomorrow but this is a preview. Are we planning on collecting the text field for 19a on the frontend? The prompt for that is Provide the name of the firm/organization here:. We do have a screen where we'll be collecting the names for the 19b text field. The prompt for that one is Provide the names of the individuals here: @cosu419 showed me that screen but it sounded like we didn't have one for the 19a text field.

What do you think @oddball-lindsay ?

oddball-lindsay commented 2 days ago

@opticbob hmmm good point on the frontend we simply ask yes or no for the 19a field: Image

But the 21-22a is looking for the name of the firm/organization to be entered in, in addition to the box being checked.

Some things to consider:

I could see two solutions at the moment:

  1. Simply check the box and leave the input blank -- when the Veteran/claimant brings the form in (or mails it in), the attorney or claims agent can complete this before signing if they want to.
  2. Add some general content like [accredited representative name]'s associated firm/organization.

I'm not sure how acceptable Option 2 is so I'm leaning towards Option 1. If you open this discussion up on Slack, I'm very curious to hear other's input!

opticbob commented 1 day ago

In regards to the above comment we are going with solution 1, checking the box and leaving it to be filled in by the accredited individual when they meet with the veteran/claimant.

The PR for this was marked ready for review today and I've requested a review from the team.