[ ] Assign this ticket to the team member(s) responsible for addressing feedback provided by Platform.
[ ] Comment on this ticket:
If the Platform reviewer has any Thoughts/Questions that require responses.
When Must feedback has been incorporated. As appropriate, link to any other GitHub issues or PRs related to this feedback.
When Should/Consider feedback has been incorporated, or if any feedback will not be addressed. As appropriate, link to any other GitHub issues or PRs related to this feedback.
[ ] Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members.
[ ] Close the ticket when all feedback has been addressed.
Thoughts/questions
-
Feedback
Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).
[ ] Should: Button to call VCL should be a va-telephone link It's not clear what the Contact the Veterans Crisis Line button does - open a modal, initiate a phone call? We do not see a button used for the VCL anywhere else on the site and this seems like a break from our button guidance. That said, if the button stays, I recommend clarifying the text to say exactly what the button does - "Call the Veterans Crisis Line now" or something similar.
[ ] Should: add a link to download the files on success page When the file download process is initiated, folks may accidentally close out of the file download, or might not know where to find the files that just downloaded. I recommend including a download link on the file download success page (maybe inside the green success alert) that allows users to click and download to a file location of their choice. This can be in addition to the auto-download, or replacing it.
Governance team actions
[x] Format feedback as individual tasks (check boxes)
[x] Assign this ticket to the VFS team member that opened the Slack request
[x] Add the VFS team product label
[x] Add the VFS team the feature label (if applicable)
[x] Add the touchpoint labels
[x] Add the practice area labels
[x] Add the Collaboration Cycle initiative milestone
Next Steps for the VFS team
@platform-governance-team-members.Thoughts/questions
-
Feedback
Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).
[ ] Should: Button to call VCL should be a
va-telephonelink It's not clear what theContact the Veterans Crisis Linebutton does - open a modal, initiate a phone call? We do not see a button used for the VCL anywhere else on the site and this seems like a break from our button guidance. That said, if the button stays, I recommend clarifying the text to say exactly what the button does - "Call the Veterans Crisis Line now" or something similar.[ ] Should: add a link to download the files on success page When the file download process is initiated, folks may accidentally close out of the file download, or might not know where to find the files that just downloaded. I recommend including a download link on the file download success page (maybe inside the green success alert) that allows users to click and download to a file location of their choice. This can be in addition to the auto-download, or replacing it.
Governance team actions