[ ] Assign this ticket to the team member(s) responsible for addressing feedback provided by Platform.
[ ] Comment on this ticket:
If the Platform reviewer has any Thoughts/Questions that require responses.
When Must feedback has been incorporated. As appropriate, link to any other GitHub issues or PRs related to this feedback.
When Should/Consider feedback has been incorporated, or if any feedback will not be addressed. As appropriate, link to any other GitHub issues or PRs related to this feedback.
[ ] Questions? For the most timely response, comment on Slack in your team channel tagging @platform-governance-team-members.
[ ] Close the ticket when all feedback has been addressed.
Thoughts/questions
Sorry for the long delay in getting this feedback to you --- and thank you for your patience! I was out sick for most of last week, and digging out from that has been a big task.
Feedback
Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).
[ ] Must: Echoing Erin's IA feedback "strengthen link text across the product" --- There are instances where link text is ambiguous about where it goes, eg. "visit this page". Link text that clearly indicates where a user is going is important for everyone, but especially for screen reader users. Many screen reader users tab through the interactive elements of a page and hear their labels announced in isolation, without any of the surrounding context. Something like "visit this page" doesn't make any sense without the surrounding context, but "Learn about potential benefits for a family member, caregiver, or survivor of a Veteran" does.
[ ] Must: In the mobile view, it looks like the filter and sort options are on their own page, correct? If so, that page needs its own distinct H1 to distinguish it from the main results page.
[ ] Coding note: For time-sensitive benefits, I would recommend either wrapping the "Time-sensitive benefit" banner into the same H3 that contains the name of the benefit, or else using aria-describedby to associate "Time-sensitive benefit" with the heading. They're not quite equivalent but either would be appropriate here.
Governance team actions
[x] Format feedback as individual tasks (check boxes)
[x] Assign this ticket to the VFS team member that opened the Slack request
[x] Add the VFS team product label
[x] Add the VFS team the feature label (if applicable)
[x] Add the touchpoint labels
[x] Add the practice area labels
[x] Add the Collaboration Cycle initiative milestone
Next Steps for the VFS team
@platform-governance-team-members.Thoughts/questions
Feedback
Practice areas will document their feedback on the VFS-provided artifacts following the Must, Should, and Consider Framework. Platform Governance reviewers may also provide additional notes that don’t comment on the artifacts themselves but are important for implementation (eg. engineering/coding notes).
aria-describedbyto associate "Time-sensitive benefit" with the heading. They're not quite equivalent but either would be appropriate here.Governance team actions