department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

Accessibility Testing for BMT II, Benefit Letters, Download Letter button text #97677

Open 1Copenut opened 3 days ago

1Copenut commented 3 days ago

Product information

Who completed the use of color and color contrast test?

@1Copenut

Use of color and color contrast checks

How did color testing go?

Color testing went well. All text is meeting minimum color contrast ratio requirements. The non-text focus halo doesn't meet 3:1 contrast ratio with white backgrounds, but this is a known issue being worked on.

Who completed the axe scans?

@1Copenut

axe checks

axe DevTools scan results

Axe testing went well. Zero issues were detected in the manual evaluation with all Benefit Letters accordions opened.

How did axe testing go?

The automated tests include axe checks for all accordions open and keyboard-driven interaction.

Who completed the content zoom and reflow test?

@1Copenut

Content zoom and reflow checks

How did content zoom and reflow testing go?

Content zoom and reflow went well. I did have one question regarding the line-height on our VA buttons. The current stylesheet shows it at 0.9, which feels fine for single line labels but crunches the leading a bit when longer labels wrap to two lines. I'm attaching a screenshot of 400% zoom for reference. Is this something we should raise to the DS team?

Image

Who completed the keyboard navigation test?

@1Copenut

Keyboard navigation checks

How did keyboard testing go?

No issues in keyboard testing.

Do you have any other results to share?

  1. Buttons do not respond to Microsoft Voice Access commands. I have root-caused this behavior and am tracking work in #96357.
  2. The screen reader experience is much improved now. Windows 11 Chrome wants to download PDFs and Firefox opens them directly in a new tab. Removing the word "Download" and adding "(PDF)" was an excellent decision by @rallencf. The prompt is much clearer now.
  3. I picked up that the buttons announce as unavailable, but are still clickable. Funny enough, the root cause of this behavior is the same one that prevents Voice Access from clicking buttons: an attribute disabled=false". Setting the local disabled prop to undefined as the baseline makes the buttons announce as "clickable" which is what we want. This too will be fixed in #96357.
dysbo commented 3 hours ago

Interesting findings with the disabled="false" issue!