department-of-veterans-affairs / va.gov-team

Public resources for building on and in support of VA.gov. Visit complete Knowledge Hub:
https://depo-platform-documentation.scrollhelp.site/index.html
284 stars 206 forks source link

Accessibility Testing for BMT Team II, Benefit Letters, Fix Voice Access not clicking buttons properly #97839

Open 1Copenut opened 6 hours ago

1Copenut commented 6 hours ago

Product information

Who completed the use of color and color contrast test?

@1copenut

Use of color and color contrast checks

How did color testing go?

No color contrast issues. The yellow focus halo has a 3:1 contrast ratio discrepancy to the white background, but this is a known issue and being remediated by the design system team.

Who completed the axe scans?

@1copenut

axe checks

axe DevTools scan results

The Benefit Letters pages have no axe issues.

How did axe testing go?

The Benefit Letters pages have adequate axe checks in the Cypress end-to-end tests for good coverage and representative user states.

Who completed the content zoom and reflow test?

@1copenut

Content zoom and reflow checks

How did content zoom and reflow testing go?

No issues found in content zoom and reflow.

Who completed the keyboard navigation test?

@1copenut

Keyboard navigation checks

How did keyboard testing go?

No issues found in keyboard testing.

Do you have any other results to share?

I made a change to the <VaButton> logic for the disabled attribute. This attribute is a Boolean in the HTML5 spec, and does not accept a "false" string or false Boolean value; it exists or it does not. Passing false as the prop value was causing Microsoft Voice Access to not register the click event on "View letters" and "Download letter" buttons. I could say "Click View letters" and nothing would happen. After I updated the logic for disabled to accept either true | undefined, null the buttons behaved correctly. I'll be filing an issue with the Design System team to fix the button logic too.

I tested this several times over several days with NVDA and Chrome, Edge, Firefox for the efficacy of removing the live regions. They were communicating too much information when users loaded the Letters page (step 2) and when users opened a letter accordion. The default behavior of our own <VaAccordion> and native <detail> components is to announce the state change but not read out the inner content. My change made the Benefit Letters match this experience.