Closed mmiddaugh closed 4 years ago
@mmiddaugh Would it be possible to provide a list of the changes y'all have made? I know the map pins is one, but I think there are additional changes to the search form, results, and the introduction text.
Tentatively scheduled for Thursday 6/18 @ 1:30 https://dsva.slack.com/archives/CBU0KDSB1/p1591796540242600?thread_ts=1591724883.199900&cid=CBU0KDSB1
Per discussion with VSP reviewers, we are going to do this review asynchronously. Reviewers will have feedback documented within ~2 business days after you are able to provide the list of changes that have been made without review @mmiddaugh
If we begin review and find that anything warrants deep discussion in a meeting format, we will reschedule a meeting accordingly.
In order to do this review, the team needs a list of changes to review.
[Coming upon this afterwards… I didn't mean that the way it sounds! :doh: ]
A few things need to be addressed before I can provide a QA review --
@mmiddaugh Hello, below is content feedback (v. minor)
The headings and labels are inconsistently styled (some sentence-cased, some are title-cased). We should follow our VA.gov styleguide of sentence-casing all labels, headings, subhead.
This isn't a launch blocker, but something that should be updated at some point.
Some examples that need to be sentence-cased: Main number Mental health Hours of operation View on map Postal code
Thank you @peggygannon
I recently made an #10289 for "Postal code" but appreciate you bringing the others to our attention. I'll add them to that issue as well.
- It looks like you have a great suite of regression tests, but it looks like the test run has yet to be executed.
@mmiddaugh @pjhill , I just finished Regression test-runs, and QA-artifact links have been updated/added in ticket description above.
NOTE: I marked a couple test-cases Retest due to some unexpected behavior, but haven't logged any defects for them as I'm not sure if any are warranted:
The unexpected behaviors might well stem from certain test-case steps becoming out-of-date. You can review the Actual Results for these cases. The Steps marked Retest will have a yellow icons,
After you've review the test-run results for these case in TestRail, it may be prudent to follow-up with a quick Slack chat or Zoom meeting so that we can decide how to address those unexpected behaviors.
Feel free to ping me on Slack if you have any interim questions/comments.
Thanks much!
@mmiddaugh @pjhill , "Staging Review" test-runs now also completed, see reports linked both below and in main Description above:
This review was suggested by Jennifer Strickland to review existing functionality in preparation for Full 508 Accessibility Review and to assess design.
Steps to complete Staging Review:
List of changes
Features/enhancements
Resolution of accessibility issues
Out of scope
Artifacts - please provide the following artifacts at least 2 days before scheduled review meeting
Required accessibility tests
Recommended tests
Experimental tests
List of known issues
Meeting attendees from requesting team
Scheduling
Additional Notes
During this collaboration point, you will receive feedback from the following practice areas: design, accessibility, content, QA, and optional: product, analytics, engineering, information architecture