search

department-of-veterans-affairs / veterans-employment-center

Veterans Employment Center
https://www.vets.gov/veterans-employment-center
5 stars 4 forks source link

Remove import from LinkedIn if Resume is imported from Skill Translator #180

Closed cfeeney-va closed 8 years ago

cfeeney-va commented 8 years ago

Fixes #108

Importing from LinkedIn redirected to a new resume with LinkedIn info, so information already imported from the skills translator is lost. Current solution is to disable import from LinkedIn if information has already been imported from the skills translator.

Created #179 to follow-up with more ideal functionality.

ayaleloehr commented 8 years ago

@cfeeney-va What you wrote up in #179 is spot on. Until we get to that point where we can merge data from multiple places, I think the best course of action is to leave the functionality as it is today (and not merge this PR). Filling out skills from the skills translator manually is much easier than filling out an entire profile of information from LinkedIn, so removing the ability to import from LinkedIn when coming from the skills translator doesn't seem like a great user experience.

FWIW, the technical solution you came up with here is really pretty awesome and the code looks great!

Going to leave this PR open for a day to see if anyone else has thoughts or feedback here.

cfeeney-va commented 8 years ago

Closing pull request; current solution is to put text on the page that warns users to save profile before linkedin import or info will be lost