search

department-of-veterans-affairs / veterans-employment-center

Veterans Employment Center
https://www.vets.gov/veterans-employment-center
5 stars 4 forks source link

Remove old skills translator code #200

Closed MarinaNitze closed 8 years ago

MarinaNitze commented 8 years ago

Believe I got everything, second set of eyes appreciated.

@cfeeney-va or @ayaleloehr ?

Fixes #72

The most helpful background context is that skills used to be stored in a "skills" array on the Veteran model, and are now stored in an association between Veteran and Skill models.

cfeeney-va commented 8 years ago

Code looks good but on testing I'm seeing really weird behavior where the skills translator page infinitely reloads itself. I think it's unrelated to these changes but troubleshooting to make sure

MarinaNitze commented 8 years ago

@cfeeney-va Alex and I realized that two important processes are, for some reason, hidden in migration files... I am working on moving them to a rake task. Not sure if that would solve your problem. My problem was the skills all seemed to disappear (which was solved by this new rake task and unrelated to this PR). But infinitely reloading is a new one...

cfeeney-va commented 8 years ago

Yeah, it was really weird but seems to be working fine now... Code LGTM, merging