search

department-of-veterans-affairs / veterans-employment-center

Veterans Employment Center
https://www.vets.gov/veterans-employment-center
5 stars 4 forks source link

Add c-and-e copy #235

Closed emilyville closed 8 years ago

emilyville commented 8 years ago

whoa this is a lot of copy to add. I'll send them screenshots for them to review and revisit.

ayaleloehr commented 8 years ago

@emilyville I fixed the tests that were broken before this PR. This PR breaks one other test, however. The pages also don't look anywhere near settled (links like "beginning of old copy" and "widget goes here" are in multiple places), so I think another iteration should be spent before merging. Going to assign back to you for that, if that works.

ayaleloehr commented 8 years ago

@emilyville broken test for ease of reference is about the hiring commitment page not having a login button. Comes from /spec/requests/employers_spec.rb lines 55-59.

emilyville commented 8 years ago

I'm closing this pr - the work is note elsewhere.