search

department-of-veterans-affairs / veterans-employment-center

Veterans Employment Center
https://www.vets.gov/veterans-employment-center
5 stars 4 forks source link

Throws exception when skill entered with apostrophe #334

Open ayaleloehr opened 8 years ago

ayaleloehr commented 8 years ago

When a user is in the resume builder and tries to manually enter a skill that contains an apostrophe, an exception is thrown. This is an example:

ActiveRecord::StatementInvalid: ERROR: syntax error at or near "ve"LINE 1: ..." WHERE (source in ('linkedin') and name ilike 'i've done a%... ^

joduinn commented 8 years ago

Whenever we do get time to fix this, can we also check that names with an apostrophe are handled without any exceptions???

ayaleloehr commented 8 years ago

O'Duinn is an acceptable name (just checked, no errors). :)

joduinn commented 8 years ago

Excellent news, thank you!

John From: Alex Yale-Loehr [mailto:notifications@github.com] Sent: Monday, May 16, 2016 7:08 PM To: department-of-veterans-affairs/veterans-employment-center veterans-employment-center@noreply.github.com Cc: O'Duinn, John JODuinn@omb.eop.gov; Comment comment@noreply.github.com Subject: Re: [department-of-veterans-affairs/veterans-employment-center] Throws exception when skill entered with apostrophe (#334)

O'Duinn is an acceptable name (just checked, no errors). :)

— You are receiving this because you commented. Reply to this email directly or view it on GitHub<%3ehttps:/github.com/department-of-veterans-affairs/veterans-employment-center/issues/334%3c#issuecomment-219574956>