search

department-of-veterans-affairs / veterans-employment-center

Veterans Employment Center
https://www.vets.gov/veterans-employment-center
4 stars 4 forks source link

Pv remove skills jobsearch #383

Closed patrickvinograd closed 7 years ago

patrickvinograd commented 7 years ago

Removal of obsolete features. Job search and skills translator front-facing features are removed entirely. There are still some skills-translator models and db tables left around because untangling them from the veteran model is tricky.

With the /employers page removed/redirected, I opted to make the /commitments page the entry point for employer login as far as specs and redirects are concerned.

ayaleloehr commented 7 years ago

Is it easy to push this branch to dev.vets.gov so we can do regression testing on it while the PR is still open?

patrickvinograd commented 7 years ago

Just deployed to dev.

ayaleloehr commented 7 years ago

None of the signing in works on dev, but I'm 98% sure that doesn't have to do with this PR and has to do with what is whitelisted on the linkedin and google oauth setups.

This then reminded me that I should add Patrick to have ownership on these login APIs. I have now added Patrick to the Google oauth console as an owner. Trying to figure out how to do the same for linkedin, but looks like we have to be connected first, so sent him that invite.

patrickvinograd commented 7 years ago

I will go ahead and push this branch to staging as well.

ayaleloehr commented 7 years ago

@patrickvinograd when I went to https://staging.vets.gov/employment/commitments and signed in with LinkedIn, I was then was redirected to https://www.dol.gov/veterans/hireaveteran/ .

Also, when I am signed in on the commitments page, can there be a Sign Out button near the top of the page under the search bar. Some of the other VEC pages have this, so hopefully it should just be a copy/paste change.

patrickvinograd commented 7 years ago

Yeah sorry, staging got overwritten by master due to a devops deploy. So post-login you got redirected to /employers which redirects to DoL. Deploying to staging again.

ayaleloehr commented 7 years ago

Now it looks great! Tested staging and commitments works as expected, as does create-resume.

ayaleloehr commented 7 years ago

LGTM with one question, which I could be swayed either way on.

patrickvinograd commented 7 years ago

Updated accordingly and deployed to staging.

patrickvinograd commented 7 years ago

Going to go ahead and merge this. If you double check and see need for any other adjustments we'll have a chance before it goes to production.