search

department-of-veterans-affairs / veterans-employment-center

Veterans Employment Center
https://www.vets.gov/veterans-employment-center
5 stars 4 forks source link

Pv add sentry #385

Closed patrickvinograd closed 7 years ago

patrickvinograd commented 7 years ago

Fixes https://github.com/department-of-veterans-affairs/vets.gov-team/issues/897

VEC is not doing any special exception handling, so relying on Sentry's default Rails integration which will capture all uncaught exceptions if SENTRY_DSN is set, which we are doing in devops with: https://github.com/department-of-veterans-affairs/devops/pull/1394

patrickvinograd commented 7 years ago

Dunno why Jenkins failed, looks like error fetching remote repo. Looking into it.

ayaleloehr commented 7 years ago

Still failing tests for some reason. Code LGTM though, given that it's just adding a gem and not making any other specific changes. We should make sure we can see errors actually showing up in Sentry before removing New Relic, but excited for this change!