Make open hours times consistent format

[gclapp]

APIs Affected

V0 Facilities

Brief Summary

Could be a feature request Currently, there are two types of times as demonstrated here:

Example from VBA_583

"hours": {
                    "Friday": "8:00AM-4:00PM",

and from VHA_640

 "hours": {
                    "Friday": "24/7",

See related issue #19

It would nice if rather than 24/7 you used the hour format 12:00AM-11:59PM (or better yet 24 hour - but I digress).

It is also incorrect. 24/7 is a presentation artifact that actually does not make sense, in the context of "Friday" there is no "7"

I noticed you also do this on your website. It's nitpicky, but technically incorrect. (here: https://www.accesstopwt.va.gov/Main/FindFacilities?LocationText=94087&Radius=50&SortOrder=0&UserLatitude=-1&UserLongitude=-1&SameDayServiceView=true)

Severity of the Issue

I can code around it, but it's a pain for the client to have to handle these cases (especially when part of the data ("/7") is wrong.

Steps to Reproduce

See API examples above.

[edpaget]

I'll add this to our roadmap and update you when we have a timeframe. I agree this data needs to be cleaned up.

[gclapp]

Today introduced a new issue - the San Jose facility started returning "AM-PM" This has been one of my test cases for weeks, so it appears it came in as a change recently. I've highlighted it below (with ** - look at open times) . I can code around it for now, but it's starting to become a mess.

{
    "data": {
        "id": "vha_640BY",
        "type": "va_facilities",
        "attributes": {
            "name": "San Jose VA Clinic",
            "facility_type": "va_health_facility",
            "classification": "Multi-Specialty CBOC",
            "website": "http://www.paloalto.va.gov/locations/sanjose.asp",
            "lat": 37.2346898600001,
            "long": -121.77807642,
            "address": {
                "mailing": {},
                "physical": {
                    "zip": "95119-1310",
                    "city": "San Jose",
                    "state": "CA",
                    "address_1": "80 Great Oaks Boulevard",
                    "address_2": "",
                    "address_3": null
                }
            },
            "phone": {
                "fax": "408-363-3044 x",
                "main": "408-363-3011 x",
                "pharmacy": "800-311-2511 x",
                "after_hours": "650-493-5000 x60462",
                "patient_advocate": "650-493-5000 x65544",
                "mental_health_clinic": "408-363-3050",
                "enrollment_coordinator": "650-493-5000 x65804"
            },
            "hours": {
                "monday": "800AM-430PM",
                "tuesday": "800AM-430PM",
                "wednesday": "800AM-430PM",
                "thursday": "800AM-430PM",
                "friday": "800AM-430PM",
                **"saturday": "AM-PM",**
                "sunday": "-"
            },
            "services": {
                "other": [
                    "Online Scheduling"
                ],
                "health": [
                    "MentalHealthCare",
                    "PrimaryCare",
                    "Audiology",
                    "Cardiology",
                    "Dermatology",
                    "Gastroenterology",
                    "Optometry",
                    "Orthopedics"
                ],
                "last_updated": "2018-10-20"
            },
            "satisfaction": {
                "health": {
                    "primary_care_urgent": 0.75,
                    "primary_care_routine": 0.86
                },
                "effective_date": "2018-05-22"
            },
            "wait_times": {
                "health": [
                    {
                        "service": "Audiology",
                        "new": 27,
                        "established": 4
                    },
                    {
                        "service": "Optometry",
                        "new": 13,
                        "established": 12
                    },
                    {
                        "service": "Cardiology",
                        "new": 6,
                        "established": 5
                    },
                    {
                        "service": "Dermatology",
                        "new": 12,
                        "established": 18
                    },
                    {
                        "service": "Orthopedics",
                        "new": 3,
                        "established": 4
                    },
                    {
                        "service": "PrimaryCare",
                        "new": 19,
                        "established": 8
                    },
                    {
                        "service": "MentalHealth",
                        "new": 5,
                        "established": 4
                    },
                    {
                        "service": "Gastroenterology",
                        "new": 19,
                        "established": 26
                    }
                ],
                "effective_date": "2018-10-15"
            }
        }
    }
}

[beaugrantham-va]

Closing stale issues.