search

department-of-veterans-affairs / vets-api

API powering VA.gov
https://api.va.gov
Other
206 stars 62 forks source link

Add error_message_ciphertext and response_ciphertext to form_submission_attempts table #18305

Closed Thrillberg closed 2 months ago

Thrillberg commented 2 months ago

Summary

This PR (partially) fixes an error I made previously when creating the form_submission_attempts table. I didn't append _ciphertext to these two fields that are encrypted. Therefore, they don't currently work. I say this only partially fixes the error because I am NOT deleting the error_message and response fields (which are currently unused and unusable). I've learned that deleting fields is tricky and, strictly speaking, unnecessary right now for me.

Related issue(s)

https://app.zenhub.com/workspaces/vagov-product-team-forms-634853151f5c6000165942bc/issues/gh/department-of-veterans-affairs/va.gov-team-forms/1613

github-actions[bot] commented 2 months ago

Backend-review-group approval confirmed.