API-39890 - Updates typeOfAddress, addressLine1, city, country, sate and zipFirstFive validations

[rockwellwindsor-va]

Summary

• Updates description in 526 json to reflect conditiionally required values
• Updates/adds validation for:
  • typeOfAddressChange
  • addressLine1
  • country
  • city
  • zipFirstFive
• Refactors zip validation method into usa and international
• Adds/updates related tests

Related issue(s)

API-39890

Testing done

• [x] New code is covered by unit tests

Screenshots

What areas of the site does it impact?

modified:   modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb
modified:   modules/claims_api/config/schemas/v2/526.json
modified:   modules/claims_api/spec/requests/v2/veterans/526_spec.rb

Acceptance criteria

• [x] I fixed|updated|added unit tests and integration tests for each feature (if applicable).
• [x] No error nor warning in the console.
• [ ] Events are being sent to the appropriate logging solution
• [x] Documentation has been updated (link to documentation)
• [x] No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
• [ ] Feature/bug has a monitor built into Datadog (if applicable)
• [ ] If app impacted requires authentication, did you login to a local build and verify all authenticated routes work as expected
• [ ] I added a screenshot of the developed feature

Requested Feedback

(OPTIONAL)What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

[github-actions[bot]]

1 Warning

:warning:

This PR changes 229 LoC (not counting whitespace/newlines). In order to ensure each PR receives the proper attention it deserves, we recommend not exceeding 200. Expect some delays getting reviews. File Summary #### Files - modules/claims_api/app/controllers/concerns/claims_api/v2/disability_compensation_validation.rb (+9/-1) - modules/claims_api/spec/requests/v2/veterans/526_spec.rb (+81/-138) #### _Note: We exclude files matching the following when considering PR size:_ ``` *.csv, *.json, *.tsv, *.txt, *.md, Gemfile.lock, app/swagger, modules/mobile/docs, spec/fixtures/, spec/support/vcr_cassettes/, modules/mobile/spec/support/vcr_cassettes/, db/seeds, modules/vaos/app/docs, modules/meb_api/app/docs, modules/appeals_api/app/swagger/, *.bru, *.pdf ``` Big PRs are difficult to review, often become stale, and cause delays.

Generated by :no_entry_sign: Danger