department-of-veterans-affairs / vets-api

API powering VA.gov
https://api.va.gov
Other
204 stars 61 forks source link

API-39291 Add log lines #18327

Closed acovrig closed 5 days ago

acovrig commented 1 week ago

Summary

Related issue(s)

Testing done

What areas of the site does it impact?

MPI profile lookups (v1 calls)

Acceptance criteria

acovrig commented 1 week ago

Why are we adding a ClaimsApi specific logger to the general MPI class? Can you describe your needs with the logs here? Trying to see if something already exists, or if we can add something sensible that everything can leverage and isn't specific to ClaimsApi

@bosawt We're troubleshooting an error (DD logs) with MPI's response. The goal is to see if we see both unable_to_locate_mpi_record log lines together and hopefully get more insight to the root issue.

On a side note, I am unsure what e.message could be (I.E. if it could contain PII) so I opted not to log e.message - If you know it wouldn't have PII, I'd love to log it.