Closed joshkimux closed 2 weeks ago
@rsmithadhoc do you think we can close this based on the updated made to memorable date?
@rsmithadhoc do you think we can close this based on the updated made to memorable date?
@caw310 I think we should keep this open to review and update the guidance. I don't believe any changes need to be made to the components themselves at this time.
Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @powellkerry @rsmithadhoc
This appears to be a "update the guidance" ticket more than a development ticket?
This appears to be a "update the guidance" ticket more than a development ticket?
@Andrew565 That's correct.
PR created: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/pull/3427
I updated the guidance, except for 'We suggest to change "memorable date" to just "date input"', since we now have Date Input and Memorable Date as separate components.
Duplicate check
This update is for:
Component
What is the name?
Memorable date
What is the nature of this update?
What problem does this solve?
Currently, the memorable date component doesn't cover key accessibility considerations brought up by @Mottie and Jasmine Friedrich. Specifically:
Additional Context
We suggest to change "memorable date" to just "date input"
We suggest to add the following bullet point to accessibility considerations:
We suggest to edit "when to use data inputs" from:
To
We suggest to edit "When to consider something else" from:
To
We suggest providing more detailed guidance on usage
This will likely take more discovery, time, and resources-- but more guidance around usage (e.g. reducing the amount of fields to match the date being input) could be invaluable for designers. USWDS guidance feels scarce compared to gov uk (where it likely was pulled from originally)