department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
60 stars 64 forks source link

Memorable date accessibility considerations #1550

Closed joshkimux closed 2 weeks ago

joshkimux commented 1 year ago

Duplicate check

This update is for:

Component

What is the name?

Memorable date

What is the nature of this update?

What problem does this solve?

Currently, the memorable date component doesn't cover key accessibility considerations brought up by @Mottie and Jasmine Friedrich. Specifically:

Additional Context

We suggest to change "memorable date" to just "date input"

We suggest to add the following bullet point to accessibility considerations:

We suggest to edit "when to use data inputs" from:

Appropriate for most dates.

To

Use the date input component to help users enter a date they can easily remember (for example, a birthday) or one they can easily look up (for example, the expiration date of a credit card).

We suggest to edit "When to consider something else" from:

"Consider a date picker for scheduling. If users are trying to schedule something, the date picker might make more sense. Be sure to also provide an option for text entry as well. Note: We do not currently have a calendar picker as part of the design system. For reference, visit the VA online scheduling tool (VAOS) to see an experimental version of a calendar picker."

To

"Do not use the date input component if users are unlikely to know the exact date of the event you’re asking about. You may consider using a date picker for scheduling, with the following caveats ⚠️

  • We do not currently have a calendar picker as part of the design system. For reference, visit the VA online scheduling tool (VAOS) to see an experimental version of a calendar picker.
  • Date pickers have not been tested for accessibility, and may lead to launch blocking issues for your product unless carefully designed with an accessibility specialist. We strongly recommend reaching out to #accessibility-help on slack for support before considering this pattern.

We suggest providing more detailed guidance on usage

This will likely take more discovery, time, and resources-- but more guidance around usage (e.g. reducing the amount of fields to match the date being input) could be invaluable for designers. USWDS guidance feels scarce compared to gov uk (where it likely was pulled from originally)

caw310 commented 1 month ago

@rsmithadhoc do you think we can close this based on the updated made to memorable date?

rsmithadhoc commented 1 month ago

@rsmithadhoc do you think we can close this based on the updated made to memorable date?

@caw310 I think we should keep this open to review and update the guidance. I don't believe any changes need to be made to the components themselves at this time.

caw310 commented 1 month ago

Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @powellkerry @rsmithadhoc

Andrew565 commented 3 weeks ago

This appears to be a "update the guidance" ticket more than a development ticket?

rsmithadhoc commented 3 weeks ago

This appears to be a "update the guidance" ticket more than a development ticket?

@Andrew565 That's correct.

rsmithadhoc commented 2 weeks ago

PR created: https://github.com/department-of-veterans-affairs/vets-design-system-documentation/pull/3427

I updated the guidance, except for 'We suggest to change "memorable date" to just "date input"', since we now have Date Input and Memorable Date as separate components.