department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
60 stars 65 forks source link

Remove cursor pointer for current page in pagination component #1851

Closed harshil1793 closed 1 year ago

harshil1793 commented 1 year ago

Bug Report

What happened

When hovering over the paging link for page 1 on a page within the VAMC (e.g., Boston news releases), the cursor changes to a hand, indicating a clickable element. However, clicking on the element does nothing.

What I expected to happen

I expected that the cursor should not change to a hand when hovering over the paging link for the current page. Clicking on the element should also have no effect since it is the current page.

Reproducing

Steps to reproduce:

  1. Go to a page on within the VAMC that has paging, like Boston news releases
  2. Hover over the paging link for page 1
  3. Confirm that the cursor changes to a hand
  4. Click on the element
  5. Confirm that nothing happens when you click the element

Urgency

How urgent is this request? Please select the appropriate option below and/or provide details

Details

Test: https://www.va.gov/boston-health-care/news-releases/

rsmithadhoc commented 1 year ago

This issue in particular originates in content-build, not the design system component.

However, there has been some discussion around whether the current page in the pagination should be clickable and focusable. This also applies to the breadcrumbs component, and there has been discussion there. I'll look into how it should be done and talk with the relevant parties to try and get a consensus on how it should work, then provide that guidance for the content-build update and ensure our components also follow that.

Links for reference:

caw310 commented 1 year ago

@rsmithadhoc can we close this since you're saying that the issues is with the content-build?

rsmithadhoc commented 1 year ago

@caw310 Yeah, I think we are good to close this one. I'll go ahead and do that.

laflannery commented 1 year ago

@rsmithadhoc I was following up on this issue as it applies to something we are using on our products. There was guidance given by CAIA for how this (breadcrumbs and pagers) should work. Currently the pager is not following this (the current page is not actionable nor focusable). Is this something I should open another ticket for or should mentioned this might be within content-build and there might be an existing ticket already for this where these updates should perhaps be directed? Let me know what the best next steps might be, thanks!