department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
40 stars 61 forks source link

Experimental Design - Feedback button accessibility improvement #2022

Open andaleliz opened 1 year ago

andaleliz commented 1 year ago

What

I'd like to propose an experiment with the positioning of the feedback button on the website. It lives on the far right side of the page, which could be easily missed by folks who are zoomed in. I wonder if we might be able to position it on the left side of the page and release it to 50% of users behind a feature flag and see what that does for engagement. If it does not move the numbers in a negative way, it would be great to make this change for all users as an accessibility improvement.

Or, we could just decide to make the change without experimenting.

Purpose

Improving accessibility for folks using magnification

Usage

This component is used across the website.

Behavior

The feedback button would be anchored on the bottom left corner of the site container, rather than the bottom right.

Examples

Here's an example of how a page would look on desktop. I moved the back to top button as well, assuming the same guidance applies for magnifiation users + it just looked weird floating out there on the right by itself.

From a code perspective, this would be a fairly easy lift: removing a CSS property from the back to top button, swapping the DOM order of the last updated text and feedback button, and removing a CSS class from the parent container of the last updated and feedback button.

button-left-example

Accessibility

See above

Guidance

N/A

Research (optional)

Here are research findings that support placement on the left side of the page being an accessibility improvement

caw310 commented 1 year ago

@andaleliz the next DSC meeting will be on Friday, Sept 8. This will be the 2nd item on the agenda. I've added you to the meeting invite.

andaleliz commented 1 year ago

@caw310 I'll be on PTO Friday so @jfriedrich-va is going to go in my place. I've added her to the calendar invite.

jrfbz commented 1 year ago

Reporting for duty, thanks!

briandeconinck commented 1 year ago

Quick summary from the DSC meeting:

andaleliz commented 1 year ago

Awesome, thank you @briandeconinck and @jrfbz for representing this issue in the design system council meeting. I will try to hunt down the team who can implement this :) (I think public websites?)

andaleliz commented 1 year ago

Update: the feedback button is owned by @clantosswett's team; I've shared this issue with her and she's going to bring it up with her team this week. She said they can put this in their backlog and determine when they might have the bandwidth to conduct the test.

@caw310 it was suggested that perhaps the design system team owns the code for the Back to Top button and would be the team to implement that piece of the experiment. Is that the case? Thanks for any info you can provide about that.

Once we have tickets in backlogs for each, I'll close out this ticket.

caw310 commented 1 year ago

@andaleliz We do own the code but we would not be responsible for test.

andaleliz commented 1 year ago

Ok thank you for confirming that @caw310! Does that mean another team could pick up the work, and if so, would your team want to do a code review?

caw310 commented 1 year ago

@andaleliz , yes if you can do the work, a DST engineer would review and approve the PR.

humancompanion-usds commented 5 months ago

@clantosswett - Did this end up getting assigned or put in the backlog?

andaleliz commented 3 months ago

@clantosswett a lot has changed with your teams since I created this last year! Did you ever get this put into a backlog or anything? I've reached out to the a11y specialists to see if anyone would like to shepherd this ticket in my absence.