department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
40 stars 61 forks source link

[Header] - Update Design with Interactions - Mobile #2302

Closed danbrady closed 3 months ago

danbrady commented 10 months ago

Description

Update Figma Header component to have the interactive designs (popup search, mega menu, mobile accordions, etc).

Details

During the initial conversion to Figma, a simple "static" Header was created. This was for designers. However, we plan to develop an official header component. Before that can happen, we will need to update the header with designs for the interactions and popups.

Interactions:

Mobile

[1] We only need one instance of this interaction to show the needed specs for developers. We do not need to show all variations of every link when it's only content differences. [2] These appear to be the same (please validate). If so, these can be made using instances from a subcomponent.

Tasks

Acceptance Criteria

Styles & Variables/Token 

caw310 commented 6 months ago

Hey team! Please add your planning poker estimate with Zenhub @babsdenney @danbrady @LWWright7

LWWright7 commented 6 months ago

@caw310 This description is pretty broad...this sounds more like an epic ticket. Maybe we need a research ticket or more info before I can point this because I think it's an 8 or 13 easily...maybe a 21?

@danbrady @babsdenney Thoughts?

danbrady commented 6 months ago

Fair point, @LWWright7! I'll update with more details.

danbrady commented 6 months ago

OK, added more information about what interactions we need to show in order to have the specs the developers need.

danbrady commented 3 months ago

@babsdenney @LWWright7 Ready for review!

LWWright7 commented 3 months ago

@danbrady looks great Dan!

Left just a minor comment in Figma. (should we organize these interaction snippets in a more formal way? dividing them by mobile/tablet/desktop?)

danbrady commented 3 months ago

Thanks @LWWright7!