Open skylerschain opened 7 months ago
@skylerschain can you attend the DSC meeting on Friday, Jan 5 to talk about this?
@caw310 What time are those again?
@skylerschain the DSC meeting is at 1pm ET on Friday. I will add you to the invite.
@caw310 Are there specific questions I can prepare to answer, or is it more of a general conversation?
@skylerschain , there isn't anything specific. Usually, it is just the request presenting the problem and how this design solves that problem and how it would be useful for other teams.
In DSC on 1/5/24 we agreed that if Skyler and DK came up with some parameters around the behavior of the links within the tabs at 400% zoom then I could switch our existing guidance to point to this new version. The parameters are:
We also discussed that there are the following now in existence on va.gov:
Behavior - Navigation
Behavior - Navigation
The Appointments tabs were requested already. We'll want to consolidate on one Tab design. I prefer the design in this request so leaning towards that.
One thing I want to be clear on, normally the Design System Team would take on this work of taking the component, standardizing, making it bullet proof for uses in other contexts, etc. But given that we are in the midst of a large and all consuming upgrade to USWDS v3 we asked Skyler and DK to do some of this work for us. Once we're past this upgrade the DST will take on this type of work again.
@davidakennedy - Any forward progress on this one? Just curious.
One update: I did recently tweak the component itself in Figma to make it more responsive to different tab labels.
We haven't figured out the answers to the questions posed above yet. But we're just getting through a major FE work phase so I think we can reprioritize this soon!
@skylerschain and I have completed some more work on this. It's in a place where we think it's ready to have the design system team take a look, ask questions, and/or move the work forward.
Here's the design file with some of the specs.
And here some overall thoughts on the options we explored in the design file:
Of the three options, Option 1 is the best choice from an accessibility perspective.
Why: The menu has a simple design on mobile screens, and doesn't hide menu items behind a toggle. Past research with other similar menus on VA.gov performed well.
As mentioned, this option is the best from an accessibility perspective, and presents a good starting point for a new component.
This version isn't viable because the horizontal scrolling on mobile would violate Success Criterion 1.4.10.
This version shows as much of the menu as possible, and only hides a portion of items on smaller screens. It doesn't avoid hiding items though.
Let me know if you all have any questions on any of this.
What
Purpose
Usage
Behavior
Examples
Accessibility
Guidance
Research (optional)
Code (optional)
Next steps
You may present your work to the Design System Council at an upcoming meeting. If you do not or cannot attend the Design Council Meeting, you can opt to get an asynchronous approval.
Submit requests to join an upcoming Design System Council meeting in #platform-design-system.
During the meeting, the Design System Council Working Group will evaluate the request and make a decision.
If your request is approved, you can add your component or pattern to the system. If you have any questions on how to add your component or pattern to the system, please reach out to the Design System Team at #platform-design-system.