department-of-veterans-affairs / vets-design-system-documentation

Repository for design.va.gov website
https://design.va.gov
37 stars 57 forks source link

Experimental Design [va-button-pair] (USWDS v3) - Allow for custom button labels #2362

Open brianseek opened 8 months ago

brianseek commented 8 months ago

What

Give a brief description of the component or pattern you want to propose.

We would like the ability to use the button pair with labels other than yes/no and back/continue. In the check-in application, we utilize yes/no for travel claim questions, but the review page uses a pair of "Agree to these terms/File later". All of these pages use the same page component but this last page means we can't use the same button pair component within it.

I dug around through the guidance both here and on the USWDS and I didn't see how different text would be counter to any of it as long as the two options were related/inverse choices.

Purpose

What problem does this component or pattern solve for the user?

Allows the user to see a more specific choice in the buttons when its needed.

Usage

Context or task: Explain the scenario or user tasks where this component is, or could be, used.

Travel pay claim within check-in.

Behavior

Describe the key interactions for this component, calling out any specific considerations for mobile.

Same as default except with different button text.

Examples

Include any examples you have of this component or pattern. These can be screenshots, links to a Sketch file, or links to staging or production.

A travel page with yes/no localhost_3001_health-care_appointment-check-in_travel-review (1) The review travel page with different button choices localhost_3001_health-care_appointment-check-in_travel-review

Accessibility

Include any accessibility considerations.

No additional accessibility considerations.

Guidance

What would you want to tell other teams about this component or pattern?

To only choose custom text with the context of the situation calls for it and to default to one of the pre-determined text choices.

Research (optional)

Include any research you have already conducted, or plan to conduct, on this component or pattern.

Code (optional)

Include any existing code.

Next steps

You may present your work to the Design System Council at an upcoming meeting. If you do not or cannot attend the Design Council Meeting, you can opt to get an asynchronous approval.

Submit requests to join an upcoming Design System Council meeting in #platform-design-system.

During the meeting, the Design System Council Working Group will evaluate the request and make a decision.

If your request is approved, you can add your component or pattern to the system. If you have any questions on how to add your component or pattern to the system, please reach out to the Design System Team at #platform-design-system.

caw310 commented 8 months ago

@brianseek This is on the agenda for the Jan 19 DSC meeting at 1pm ET. I've added you to the meeting invite.

benbrasso-agile6 commented 8 months ago

@kellysmith1008 @cgednalske

caw310 commented 7 months ago

Notes from DSC meeting. Final Decision

Action Items

https://docs.google.com/document/d/1wUDWXs0BOKgeAVTqb5ZOJpICCjrbyaQB7uJ0zDkINhE/edit?usp=sharing

caw310 commented 1 month ago

Here is the ticket to update content style guide for button label text. https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/3168

caw310 commented 1 month ago

This is the ticket for development work to allow for custom button labels. https://github.com/department-of-veterans-affairs/vets-design-system-documentation/issues/3167