Open powellkerry opened 8 months ago
This is being set using an external 3rd party npm package foundation-sites
. The declaration can be found here: vets-website/node_modules/foundation-sites/scss/foundation/components/_global.scss
on line 329 & 504
The package dependency was added to vets-website 5 years ago
Formation relies on the foundation-sites
package for layout variables and normalization. I have tried to remove the package and it seems pretty intertwined with formation styles.
Missing variables that I have come accross in briefly researching this: $column-gutter $white
Formation also imports stylesheets used for grid layouts from the foundation-sites
package.
I think this would be a pretty heavy undertaking to extract this package from formation. It may make more sense to wait until formation is deprecated.
Hey team! Please add your planning poker estimate with Zenhub @Andrew565 @ataker @harshil1793 @it-harrison @jamigibbs @micahchiang @nickjg231 @powellkerry @rmessina1010 @rsmithadhoc
Bug Report
What happened
Body color is set to #222 in _global.scss. This is overwritten to its correct value of #1b1b1b, but we need to clean up the cruft.
See this comment on another ticket for context: https://github.com/department-of-veterans-affairs/vets-website/pull/27382#issuecomment-1885298753
Inspector screenshot:
What I expected to happen
The body color should always be #1b1b1b
Urgency
How urgent is this request? Please select the appropriate option below and/or provide details
Details
See vets-website homepage to replicate